docker-compose (v1) vs docker compose (v2) issue

[criadoperez]

There seems to be a mix of the usage of docker compose v1 and v2. As the binary to execute changes, it can cause some issues in the code. docker-compose is used on v1 and docker compose in v2.

As docker-compose is no longer receiving updates since July 2023, I'm assuming the desired behavior is to only use v2, which coincides with what's mentioned on the Readme.md file on line 79: docker compose ps.

Usage of compose v2 on this repo in these locations:

docs/ci/actions.md:73:* External docker images used in the [docker compose file]. For each image the
docs/ci/actions.md:74:code compares the digest existing in the docker compose file with the digest
docs/ci/actions.md:95:[docker compose file]: ../../docker-compose.yml
docs/ci/opsman.md:8:container name (as defined in the [docker compose file]) and a variadic parameter
docs/ci/opsman.md:26:[docker compose file]: ../../docker-compose.yml
README.md:79:docker compose ps

Usage of compose v1 on this repo in these locations:

docs/snap_restore.md:82:docker-compose up -d zkevm-sh
docs/snap_restore.md:83:docker-compose exec zkevm-sh /bin/sh
tools/executor/main.go:30:              cmd := exec.Command("docker-compose", "down", "--remove-orphans")
tools/executor/main.go:37:      cmd := exec.Command("docker-compose", "up", "-d", "executor-tool-db")
tools/executor/main.go:43:      cmd = exec.Command("docker-compose", "up", "-d", "executor-tool-prover")
tools/executor/README.md:73:docker-compose up -d zkevm-sync
test/Makefile:1:DOCKERCOMPOSE := docker-compose -f docker-compose.yml
test/Makefile:83:RUNDACDB := docker-compose up -d cdk-validium-data-node-db
test/Makefile:84:STOPDACDB := docker-compose stop cdk-validium-data-node-db && docker-compose rm -f cdk-validium-data-node-db

As an example, one issue (but they may be more), is that if you follow the steps on the Readme file and have only compose v2 installed, it will not work unless you change on the test/Makefile line 1 from this:

DOCKERCOMPOSE := docker-compose -f docker-compose.yml

to this:

DOCKERCOMPOSE := docker compose -f docker-compose.yml