Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add VerifiedTransaction #1121

Open
PhilippGackstatter opened this issue Feb 4, 2025 · 0 comments
Open

Add VerifiedTransaction #1121

PhilippGackstatter opened this issue Feb 4, 2025 · 0 comments
Milestone

Comments

@PhilippGackstatter
Copy link
Contributor

What should be done?

Add VerifiedTransaction struct to ProvenBatch.

Basically, right now, a block does not contain enough info to figure out what happened in a given transaction. This is not something that is critical for building blocks, but it would be nice to have this info to show to the user.
#919 (comment)

How should it be done?

Add the struct (roughly) as defined in #919 (comment).

These should be created from a ProvenTransaction after they were verified in LocalBatchProver::prove.
We then probably should include VerifiedTransaction in a ProvenBatch.

One open question to me is whether ProvenBatch will end up in a Block or not. Then the block would actually contain all the interesting data for the explorer to show I believe.

When is this task done?

Presumably when the block contains enough information so that it's possible (in the explorer, for example)

[...] to show which nullifiers were consumed in the transaction and which output notes were created.
#919 (comment)

Additional context

No response

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants