Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use new faucets in tests #912

Open
igamigo opened this issue Oct 8, 2024 · 0 comments
Open

Use new faucets in tests #912

igamigo opened this issue Oct 8, 2024 · 0 comments

Comments

@igamigo
Copy link
Collaborator

igamigo commented Oct 8, 2024

Would be great to add a test for this, but #871 is pretty big as is. Let's create an issue for this and we'll tackle it in a separate PR.

Originally posted by @bobbinth in #911 (review)

Basically the tests in the miden-base repo are using non-new faucets which causes some validations to be skipped. We should either modify a test to execute with a new faucet, or create a new one. Additionally, create_new_basic_fungible_faucet is not tested in an execution environment (outside of miden-client), so maybe that could be addressed as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant