Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add transaction recency validations for TransactionRequest #567

Open
igamigo opened this issue Oct 30, 2024 · 0 comments
Open

Add transaction recency validations for TransactionRequest #567

igamigo opened this issue Oct 30, 2024 · 0 comments

Comments

@igamigo
Copy link
Collaborator

igamigo commented Oct 30, 2024

Considering new features/restrictions, there are a couple validations we should add to Client::validate_request():

  • In regards to Require transactions to refer to recent blocks miden-base#933, we should check beforehand that the client is at a fairly recent block.
  • In regards to foreign-procedure invocations with public accounts, we want to make sure the public data we receive from the node is fairly close to the current client's sync height
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@igamigo