FailedAssertion error code should be displaying as integer

[frisitano]

When displaying the error code associated with a failed assertion we should display it as an integer instead of a field element.

miden-vm/processor/src/errors.rs

Lines 88 to 90 in c097af7

	FailedAssertion(clk, err_code) => {
	write!(f, "Assertion failed at clock cycle {clk} with error code {err_code}")
	}

[bobbinth]

The above code should print out Felt as an integer (Display implementation on Felt calls as_int() method). Are there some other places where it is being printed out differently?

[frisitano]

The above code should print out Felt as an integer (Display implementation on Felt calls as_int() method). Are there some other places where it is being printed out differently?

Yes, when a program panics due to a failed .unwrap() the Felt appears to be displayed in Montgomery form. It's possible this is because it's being displayed using the Debug derivation. Maybe we should implement Debug using .as_int() on Felt instead of #1148?

[bobbinth]

Yes, when a program panics due to a failed .unwrap() the Felt appears to be displayed in Montgomery form.

Ah! Makes sense.

It's possible this is because it's being displayed using the Debug derivation. Maybe we should implement Debug using .as_int() on Felt instead of #1148?

Yes, I think that's what's probably is going on. And yes, I think it would probably be better to print out the actual integer value for Debug as well (and if someone needs to print out the internal value, they can use inner() method).

[bobbinth]

@frisitano - since facebook/winterfell#228 has been merged, we can probably close this issue?