Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

N13 - msg.sender is defined as operator during _mint and _burn #43

Open
PhABC opened this issue Jan 6, 2020 · 2 comments
Open

N13 - msg.sender is defined as operator during _mint and _burn #43

PhABC opened this issue Jan 6, 2020 · 2 comments

Comments

@PhABC
Copy link
Contributor

PhABC commented Jan 6, 2020

image

By @Agusx1211

@PhABC
Copy link
Contributor Author

PhABC commented Jan 7, 2020

I guess the definition of what an operator is is quite unprecise.

  • If Bob calls a contract C that transfers Alice's tokens, is contract C (msg.sender) the operator or is it Bob?

  • If Bob calls a contract C that mints tokens to Alice, is contract C (msg.sender) the operator or is it Bob?

I could see arguments for Bob or C being the operator in the events, but it depends on the goal indeed. This is related to #27 as well. The standard seems to indicate that C should be the operator (since C is approved to transfer Alice's tokens, not Bob directly), but Bob is the one initiating the transfer.

@Agusx1211
Copy link
Member

but Bob is the one initiating the transfer.

Bob may only be convening the intent of C, who can determine if the token get's transferred or not. Maybe when thinking about a meta-transaction is a little bit brighter, during a meta-transaction, Bob would be the "relayer," and it would only be executing the intent of the signer, which is the real operator.

Overall, I agree that the definition of operator on ERC-1155 is quite unprecise.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants