Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only reset session id if there is no connected wallet address - witho… #244

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

BellringerQuinn
Copy link
Contributor

…ut this, the flow to re-use the login panel from our docs (setting a connected wallet address) is broken - the waas api will reject the federate auth attempt as you will be using an un-authenticated session id

Version Increment

Please ensure you have incremented the package version in the package.json as necessary.

  • I have incremented the package.json according to semantic versioning
  • No version increment is needed; the change does not impact SDK or Sample code/assets

Docs Checklist

Please ensure you have addressed documentation updates if needed as part of this PR:

  • I have created a separate PR on the sequence docs repository for documentation updates: Link to docs PR
  • No documentation update is needed for this change.

…ut this, the flow to re-use the login panel from our docs (setting a connected wallet address) is broken - the waas api will reject the federate auth attempt as you will be using an un-authenticated session id
@BellringerQuinn BellringerQuinn requested review from a team as code owners February 6, 2025 21:18
Copy link

cloudflare-workers-and-pages bot commented Feb 6, 2025

Deploying sequence-unity with  Cloudflare Pages  Cloudflare Pages

Latest commit: 0b6a670
Status: ✅  Deploy successful!
Preview URL: https://9013ae4a.sequence-unity.pages.dev
Branch Preview URL: https://fix-federateauth.sequence-unity.pages.dev

View logs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant