Feature/marketplace checkout #251
Draft
+25,967
−6,888
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…pendant classes to the Integrations assembly so that Marketplace assembly can inherrit from Integrations assembly (using Transak and Sardine)
…ctibles and add missing tests
…tive names and fix implementation to new endpoint configuration and update test namings
…ntation and tests
…reating separate json converters for each enum
…m told I have invalid calldata when opening the link. I am also needing to mock the gas estimation as my estimator thinks the transaction will revert (which makes sense as I wouldn't be executing)
* FirstCommitForQr Qr Setup and exposure with link to add funds for the respective order chain id in native token address * More automatization on adding funds Detecting specifics straight from collectible order * Automated inputs for QR Included automated inputs for adding funds via qr transfer link. Fills Qr with selected order Order component information. * Updated qr token address setting Made check for nativetokenaddress placeholder to use in case ChainTokenAddress.Get(),(renamed) and also made some minor ui text updates. * Standarized to EIP-618 transfer link It includes all etheremum eip-618 compatible wallets (metamask is such). Also revisions on price names and formats
v1.9.5
…ts and tests. Don't allow offers with native currencies.
…lter Sardine tokens responses based on network. Test refactoring.
…h intellisense summaries. Added some pre-emptive error handling for SardineCheckout - throwing exceptions for operations now supported by Sardine like using native tokens
…tatic classes and add tests to confirm they work (using examples from kit)
… wrapper such that we use fixed bytes instead as this is less error prone
…at we don't lose accuracy when sending large numbers via API for an integrator - might as well stay as a modification to the test to confirm this remains the case
…rder - this can be retrieved as any MarketplaceKind that isn't one of the sequence marketplace versions is reservoir OrderbookKind
…Integrations asmdef to SequencePay
…or fiat checkout) and updated MarketplaceCheckout interfaces such that they support buying/selling multiple orders for the same item
Deploying sequence-unity with
|
| Latest commit: |
cc11ca7
|
| Status: | 🚫 Build failed. |
… Dictionaries as a key and not encounter issues with value comparison
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When looking at this draft PR, it is recommended to first checkout this class diagram: https://github.com/0xsequence/sequence-unity/blob/Feature/marketplaceCheckout/Packages/Sequence-Unity/Sequence/SequenceSDK/Marketplace/ERG_CheckoutModal.mmd
#248 is pre-requisite
Version Increment
Please ensure you have incremented the package version in the package.json as necessary.
Docs Checklist
Please ensure you have addressed documentation updates if needed as part of this PR: