From 8f782b7c9999ee78c857aa174ee99dfd17686d93 Mon Sep 17 00:00:00 2001 From: Tolgahan Arikan Date: Wed, 8 Nov 2023 14:19:46 +0300 Subject: [PATCH] Update todo --- packages/auth/src/services.ts | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/packages/auth/src/services.ts b/packages/auth/src/services.ts index 083c0e087..b2bdc0973 100644 --- a/packages/auth/src/services.ts +++ b/packages/auth/src/services.ts @@ -203,7 +203,7 @@ export class Services { ethAuth.chainId = chainId.toNumber() // TODO: Modify ETHAuth so it can take a provider instead of a url - // QUESTION/TODO: should we make projectAccessKey non-optional in services so we can be sure this provider will have proper rpcUrl? + // TODO: Make sure 'network.rpcUrl' has the proper projectAccessKey ethAuth.provider = new ethers.providers.StaticJsonRpcProvider(getDefaultConnectionInfo(network.rpcUrl), { name: '', chainId: chainId.toNumber() @@ -287,7 +287,7 @@ export class Services { if (!network) throw Error('No network found') ethAuth.chainId = chainId.toNumber() // TODO: Modify ETHAuth so it can take a provider instead of a url - // QUESTION/TODO: should we make projectAccessKey non-optional in services so we can be sure this provider will have proper rpcUrl? + // TODO: Make sure 'network.rpcUrl' has the proper projectAccessKey ethAuth.provider = new ethers.providers.StaticJsonRpcProvider(getDefaultConnectionInfo(network.rpcUrl), { name: '', chainId: chainId.toNumber()