-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cleanup the management commands #128
Comments
The problem is that we don't have a single command to add a new study, how do we usually add them? I will fuse the instructions in compute_n_hits, import_publication_links and import_sample_number in one command and remove generate_complete_csv. |
So I see it as follows: |
Ok, I will delete the other commands and create a new one for new studies (as proposed in #31 ). However we base all the current pipeline on the fact that studies, phenotypes and hdf5 files always carry the same id, can we keep this assumption for the future? (i.e. will the file be named 289.hdf5?) |
No we can't. This is purely a coincidance because we currently have a 1-1 mapping between phenotypes and GWAS studies (1 transformation, 1 method and 1 genotype). As soon as we introduce either a new method or a new genotype version this does not uphold. |
Left compute_n_hits for now so to update permutation thresholds once computations are done. Will delete it afterwards. #128
Currently there are a lot of mangement commands:
Some of them were workarounds to get the data in. We should remove those.
So far I think submit_to_datacite, setup_es, index_study, import_phenotypes are definitely required. Not sure about the others.
The import_phenotypes should have an option to update the phenotype information if they already exists.
The text was updated successfully, but these errors were encountered: