From 130fde4ecacf8e35468912f5d96b63fe19fd1905 Mon Sep 17 00:00:00 2001 From: Pushpam <93931528+Decoder07@users.noreply.github.com> Date: Tue, 23 Jul 2024 12:41:53 +0530 Subject: [PATCH] Fixed noise cancellation property on android from dashboard (#1798) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit * Fixed noise cancellation property on android from dashboard * 🤖 Automated Format and Fix * released sample app version 1.5.212 (512) 🍀 * Changed branch to dev-v2 * released sample app version 1.5.213 (513) 🍀 * Updated android sdk version to 2.9.64 * updated changelog * released sample app version 1.5.214 (514) 🍀 --------- Co-authored-by: Decoder07 --- .../lib/src/meeting/meeting_store.dart | 13 +++++++++++- .../example/ExampleAppChangelog.txt | 5 ++++- .../example/android/app/build.gradle | 4 ++-- .../hmssdk_flutter/example/ios/Gemfile.lock | 20 +++++++++---------- .../example/ios/Runner/Info.plist | 4 ++-- ...HMSNoiseCancellationControllerAction.swift | 2 +- .../lib/assets/sdk-versions.json | 2 +- 7 files changed, 32 insertions(+), 18 deletions(-) diff --git a/packages/hms_room_kit/lib/src/meeting/meeting_store.dart b/packages/hms_room_kit/lib/src/meeting/meeting_store.dart index 111f93c49..a3730dd64 100644 --- a/packages/hms_room_kit/lib/src/meeting/meeting_store.dart +++ b/packages/hms_room_kit/lib/src/meeting/meeting_store.dart @@ -2511,11 +2511,22 @@ class MeetingStore extends ChangeNotifier void checkNoiseCancellationAvailability() async { isNoiseCancellationAvailable = await _hmsSDKInteractor.isNoiseCancellationAvailable(); + + ///Here we check if noise cancellation is available, if its available + ///then we check if its enabled from dashboard in the default configuration + ///If yes we enable it. + ///Else we check the noise cancellation status to update the UI if (isNoiseCancellationAvailable) { isNoiseCancellationEnabled = await _hmsSDKInteractor.isNoiseCancellationEnabled(); + if ((HMSRoomLayout.roleLayoutData?.screens?.conferencing?.defaultConf + ?.elements?.noiseCancellation?.enabledByDefault ?? + false) && + !isNoiseCancellationEnabled) { + _hmsSDKInteractor.enableNoiseCancellation(); + isNoiseCancellationEnabled = true; + } } - notifyListeners(); } void toggleWhiteboard() async { diff --git a/packages/hmssdk_flutter/example/ExampleAppChangelog.txt b/packages/hmssdk_flutter/example/ExampleAppChangelog.txt index ec149dcb3..e6440bf71 100644 --- a/packages/hmssdk_flutter/example/ExampleAppChangelog.txt +++ b/packages/hmssdk_flutter/example/ExampleAppChangelog.txt @@ -9,7 +9,10 @@ https://app.devrev.ai/100ms/works/ISS-22858 - Sample application not able to access microphone from background in android 14. https://app.devrev.ai/100ms/works/ISS-22907 +- Transciption replaces older transcription from view +https://app.devrev.ai/100ms/works/ISS-22845 + Room Kit: 1.1.5 Core SDK: 1.10.5 -Android SDK: 2.9.62 +Android SDK: 2.9.64 iOS SDK: 1.13.0 diff --git a/packages/hmssdk_flutter/example/android/app/build.gradle b/packages/hmssdk_flutter/example/android/app/build.gradle index 459cfe2be..3be7e0758 100644 --- a/packages/hmssdk_flutter/example/android/app/build.gradle +++ b/packages/hmssdk_flutter/example/android/app/build.gradle @@ -36,8 +36,8 @@ android { applicationId "live.hms.flutter" minSdkVersion 21 targetSdkVersion 34 - versionCode 511 - versionName "1.5.211" + versionCode 514 + versionName "1.5.214" } signingConfigs { diff --git a/packages/hmssdk_flutter/example/ios/Gemfile.lock b/packages/hmssdk_flutter/example/ios/Gemfile.lock index fee179fb2..795ca6aea 100644 --- a/packages/hmssdk_flutter/example/ios/Gemfile.lock +++ b/packages/hmssdk_flutter/example/ios/Gemfile.lock @@ -15,19 +15,19 @@ GEM artifactory (3.0.17) atomos (0.1.3) aws-eventstream (1.3.0) - aws-partitions (1.949.0) - aws-sdk-core (3.200.0) + aws-partitions (1.955.0) + aws-sdk-core (3.201.1) aws-eventstream (~> 1, >= 1.3.0) aws-partitions (~> 1, >= 1.651.0) aws-sigv4 (~> 1.8) jmespath (~> 1, >= 1.6.1) - aws-sdk-kms (1.87.0) - aws-sdk-core (~> 3, >= 3.199.0) - aws-sigv4 (~> 1.1) - aws-sdk-s3 (1.155.0) - aws-sdk-core (~> 3, >= 3.199.0) + aws-sdk-kms (1.88.0) + aws-sdk-core (~> 3, >= 3.201.0) + aws-sigv4 (~> 1.5) + aws-sdk-s3 (1.156.0) + aws-sdk-core (~> 3, >= 3.201.0) aws-sdk-kms (~> 1) - aws-sigv4 (~> 1.8) + aws-sigv4 (~> 1.5) aws-sigv4 (1.8.0) aws-eventstream (~> 1, >= 1.0.2) babosa (1.0.4) @@ -44,7 +44,7 @@ GEM domain_name (0.6.20240107) dotenv (2.8.1) emoji_regex (3.2.3) - excon (0.110.0) + excon (0.111.0) faraday (1.10.3) faraday-em_http (~> 1.0) faraday-em_synchrony (~> 1.0) @@ -170,7 +170,7 @@ GEM json (2.7.2) jwt (2.8.2) base64 - mini_magick (4.13.1) + mini_magick (4.13.2) mini_mime (1.1.5) minitest (5.22.3) multi_json (1.15.0) diff --git a/packages/hmssdk_flutter/example/ios/Runner/Info.plist b/packages/hmssdk_flutter/example/ios/Runner/Info.plist index 473c97cd5..a59452617 100644 --- a/packages/hmssdk_flutter/example/ios/Runner/Info.plist +++ b/packages/hmssdk_flutter/example/ios/Runner/Info.plist @@ -21,7 +21,7 @@ CFBundlePackageType APPL CFBundleShortVersionString - 1.5.211 + 1.5.214 CFBundleSignature ???? CFBundleURLTypes @@ -48,7 +48,7 @@ CFBundleVersion - 511 + 514 ITSAppUsesNonExemptEncryption LSApplicationCategoryType diff --git a/packages/hmssdk_flutter/ios/Classes/Actions/HMSNoiseCancellationControllerAction.swift b/packages/hmssdk_flutter/ios/Classes/Actions/HMSNoiseCancellationControllerAction.swift index c7e708265..e3a7f6427 100644 --- a/packages/hmssdk_flutter/ios/Classes/Actions/HMSNoiseCancellationControllerAction.swift +++ b/packages/hmssdk_flutter/ios/Classes/Actions/HMSNoiseCancellationControllerAction.swift @@ -33,7 +33,7 @@ class HMSNoiseCancellationController { static func createPlugin() { noiseCancellationController = { if let pathForNCModel = HMSNoiseCancellationModels.path(for: .smallFullBand) { - return HMSNoiseCancellationPlugin(modelPath: pathForNCModel, initialState: .enabled) + return HMSNoiseCancellationPlugin(modelPath: pathForNCModel, initialState: .disabled) } else { assertionFailure("Noise cancellation model was not found") } diff --git a/packages/hmssdk_flutter/lib/assets/sdk-versions.json b/packages/hmssdk_flutter/lib/assets/sdk-versions.json index a0478b1f5..e2668a540 100644 --- a/packages/hmssdk_flutter/lib/assets/sdk-versions.json +++ b/packages/hmssdk_flutter/lib/assets/sdk-versions.json @@ -4,5 +4,5 @@ "iOSBroadcastExtension": "0.0.9", "iOSHLSPlayerSDK": "0.0.2", "iOSNoiseCancellationModels": "1.0.0", - "android": "2.9.62" + "android": "2.9.64" }