Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate styles #3848

Closed
1 task done
Tracked by #3839
beechnut opened this issue Jun 4, 2024 · 1 comment
Closed
1 task done
Tracked by #3839

Migrate styles #3848

beechnut opened this issue Jun 4, 2024 · 1 comment
Assignees

Comments

@beechnut
Copy link
Contributor

beechnut commented Jun 4, 2024

One of the things I'm noticing is that the link to the styles CSS is the only broken link in the site right now:

Check HTML Links
  πŸ“– Found 1051 files containing
    πŸ”— 46998 internal links
  πŸ‘€ Checking...
  ❌ Found 1 missing reference targets (used by 957 links) while checking 1051 files:
    1. missing reference target _site/assets/css/styles.css
      from _site/2014/03/12/coming-soon/index.html:60:8 via href="/assets/css/styles.css"
      from _site/2014/03/19/hello-world-we-are-18f/index.html:60:8 via href="/assets/css/styles.css"
      from _site/2014/03/21/29-minutes/index.html:60:8 via href="/assets/css/styles.css"
      ... 954 more references to this target

Acceptance criteria

Preview Give feedback
@jasnakai
Copy link
Contributor

Consolidted the styles so that they visually match the live 18F website. Moved the relevant files from _sass to the assets/common/styles folder. Deleted the duplicate/unnecessary files and the _sass folder. Removed references to the _sass folder.
The CSS could use a cleanup since the styles from two sites were combined. I will do what I can but not get caught up on it.
Branch name: jn/fix-styles-link

@jasnakai jasnakai mentioned this issue Jun 28, 2024
1 task
@beechnut beechnut closed this as completed Jul 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants