Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggestion: Use middlewares? #3

Open
halvardssm opened this issue Jun 2, 2020 · 5 comments
Open

Suggestion: Use middlewares? #3

halvardssm opened this issue Jun 2, 2020 · 5 comments

Comments

@halvardssm
Copy link

Hi! I made some middlewares for Oak, which you might enjoy (seeing you are using djwt).

One of the middlewares is for JWT validation (though I see you already have your own implementation of this). If you would like to use this middleware, I would love some feedback 👍

I have two other middlewares as well, but I am not sure if you might need them. One is for request-body and parameter validation (very much still in development, but works), and the other one is for logging and error handling.

Hope this is useful for you 🚀

@gungunfebrianza
Copy link

hello halvardssm gonna test your framework, tq

@gungunfebrianza
Copy link

Trying to test this code but seems buggy and the module used here is obselete, gonna rewrite the new one.

@halvardssm
Copy link
Author

Oh? Which parts are obsolete?

@gungunfebrianza
Copy link

gungunfebrianza commented Jun 2, 2020

  1. first in the nessi module, we need to import dbDialects and nessieConfig.
  2. when we try to compare hashed password author forgot to add await statement (source model user.ts)
  3. wrong logic after we compare hashed password

honestly, will make new comer desperate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants
@gungunfebrianza @halvardssm and others