Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Template editor doesn't (always) save content #607

Closed
SCullman opened this issue Jan 26, 2016 · 7 comments
Closed

Template editor doesn't (always) save content #607

SCullman opened this issue Jan 26, 2016 · 7 comments

Comments

@SCullman
Copy link
Contributor

I was working on a token template with 2sxc 8.1.1/ dnn7.4.2 and noticed that my changes were not saved. If i click on save, the "saved" toast appears, though the template remains unchanged in file system. This happens most the time, I cant detect a pattern.

And yes, I did CRTL+ F5 before, tested with IE and Chrome

@SCullman
Copy link
Contributor Author

Ok, it looks like changes to an existing line remain undetected.
Once a new line is added, the former changes will be saved, but not he new line with new content.

@iJungleboy
Copy link
Contributor

Thanks - possibly a bug in the ACE editor. Could it be that it's only if you click-add a snippet, or does it also happen when you type?

@SCullman
Copy link
Contributor Author

It is independent from snippets.

@iJungleboy
Copy link
Contributor

Thanks, will review.

@iJungleboy
Copy link
Contributor

Seems to be a known angular-ui-ace bug - angular-ui/ui-ace#133 - will have to wait for a fix...
and same issue here: angular-ui/ui-ace#97

@iJungleboy
Copy link
Contributor

I was able to reproduce it, but only on snippets. To aid in debugging I added an advanced mode to the dialog (enter with ctrl-Click) - which shows the view-model as is. When i'm using snippets, they don't appear till I type some more. But if I just type, it's always updated.

Could you confirm this when we release 8.1.3?

@iJungleboy
Copy link
Contributor

made a workaround...

@iJungleboy iJungleboy modified the milestones: 2sxc 8.01.04 Quick-Fixes, 2sxc 8.01.03 Quick-Fixes Feb 9, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants