Skip to content
This repository has been archived by the owner on Jul 16, 2024. It is now read-only.

zip_size can be undefined #54

Open
awlong opened this issue Feb 17, 2022 · 0 comments
Open

zip_size can be undefined #54

awlong opened this issue Feb 17, 2022 · 0 comments

Comments

@awlong
Copy link

awlong commented Feb 17, 2022

if variables['fail_on_too_big'] and zip_size > variables['max_lambda_size']:

if the shutil.make_archive call fails (due to a multiprocessing race condition on mkdir), the process will throw out of the initial try/catch block and then throw again which blocks a return code from being captured by the Process.

Need to either check the process exitcode when joining or account for that undefined zip_size and return a breaking error code

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant