Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can EditSuffix and/or EditDisable be supported on the IRC bridge? #2073

Open
geekosaur opened this issue Sep 7, 2023 · 1 comment · May be fixed by #2207
Open

Can EditSuffix and/or EditDisable be supported on the IRC bridge? #2073

geekosaur opened this issue Sep 7, 2023 · 1 comment · May be fixed by #2207
Labels
enhancement New feature or request

Comments

@geekosaur
Copy link

Is your feature request related to a problem? Please describe.
Various people on the the IRC channels I'm bridging Matrix to have requested that edits be disabled instead of sending near-duplicate messages.

Describe the solution you'd like
Ideally EditDisable would work with the IRC bridge.

Describe alternatives you've considered
I don't think there are any real alternatives since there seems to be no way to identify an edit on Matrix by the time it reaches the IRC bridge.

Additional context
On a whim, I tried adding similar code to that present in the Matrix and Discord bridges, but it appears that msg.ID is not set at that point, presumably because IRC doesn't have message IDs. That said, I would have expected the Matrix message ID to be present somewhere, or some other indication that it's an edit from a service that supports them.

@geekosaur geekosaur added the enhancement New feature or request label Sep 7, 2023
@divVerent
Copy link

This actually seems to be needed on the Matrix bridge. In my case I wanted EditSuffix to work, and managed to just add that code to the Matrix bridge, even without message IDs.

divVerent added a commit to divVerent/matterbridge that referenced this issue Jan 17, 2025
@divVerent divVerent linked a pull request Jan 17, 2025 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants