-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Broken decoding of Issue without a body (when its a PR) #233
Comments
Good catch @YarekTyshchenko, we have two different operations for Issues and PRs. I'm wondering what will be the right behavior here. I guess the easy one is just to make optional the body in the |
Could filter out PRs from the issue endpoint, but it would cause unnecessary traffic. I'd be happy with an Optional body for now, since even in the docs they tell you to filter them yourself based on the presence of the pr urls field |
I've done some debugging. That test is failing because issue #1 has a body, and the test expects an empty body. But if we use other issue with an empty body (that is a PR), like #154 , instead of receiving and empty body decoded to More debugging is needed to know why that is happening 🤔 |
I've seen this before, Some PRs have empty body (from json response |
I create my PRs with |
🤔 |
Issues endpoints also return PRs. Body in a PR is
Option
, but isn't inIssue
. This breaks at runtime during deserialisation.The text was updated successfully, but these errors were encountered: