Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PEP8 violating class name PrometheusApiClientException #239

Open
chauhankaranraj opened this issue Apr 13, 2022 · 0 comments
Open

PEP8 violating class name PrometheusApiClientException #239

chauhankaranraj opened this issue Apr 13, 2022 · 0 comments

Comments

@chauhankaranraj
Copy link
Collaborator

Describe the bug
The PrometheusApiClientException class naming violates pep8 N818 naming convention. So this is resulting in pre-commit-check failing on every PR, even if the PR is not related to this class.

To Reproduce
Steps to reproduce the behavior:

  1. Submit a PR
  2. Let aicoe-ci/pre-commit-check run
  3. See error

Expected behavior
pre-commit-check passes

Screenshots
the following is from #238, but same applies to #232, #235
Screenshot from 2022-04-13 17-53-48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@chauhankaranraj