Week8 Project Assignment Feedback

[tienyulin]

1. What is the difference between find and find_origin_id? It seems like they use the same id

   PapMon/app/controllers/app.rb

   Line 33 in d4e1889

   paperswithcode_paper = PapersWithCode::PaperMapper.new.find(id)

   
   

   PapMon/app/controllers/app.rb

   Line 46 in d4e1889

   paperswithcode_paper = Repository::For.klass(Entity::Paper).find_origin_id(id)

2. Please these commented-out codes
   

   PapMon/app/models/entities/dataset.rb

   Line 18 in d4e1889

   # to_hash.reject { |key, _| %i[id owner contributors].include? key }

   
   

   PapMon/app/models/entities/paper.rb

   Line 21 in d4e1889

   # attribute :authors, Array.of(String).optional

   
   

   PapMon/app/models/entities/paper.rb

   Line 27 in d4e1889

   # to_hash.reject { |key, _| %i[id owner contributors].include? key }

   
   

   PapMon/app/models/entities/repository.rb

   Line 14 in d4e1889

   # attribute :origin_id, String.optional

   
   

   PapMon/app/models/entities/repository.rb

   Line 17 in d4e1889

   # to_hash.reject { |key, _| %i[id owner contributors].include? key }

   
   

   PapMon/app/models/mappers/dataset_mapper.rb

   Lines 45 to 47 in d4e1889

   	# def full_name
   	# @data['full_name']
   	# end

   
   

   PapMon/app/models/mappers/repository_mapper.rb

   Lines 39 to 45 in d4e1889

   	# def owner
   	# @data['owner']
   	# end
   	# def repo_name
   	# @data['name']
   	# end