Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Example tests download firmware-action from releases instead of compilation #413

Closed
AtomicFS opened this issue Nov 14, 2024 · 1 comment · Fixed by #406
Closed

Example tests download firmware-action from releases instead of compilation #413

AtomicFS opened this issue Nov 14, 2024 · 1 comment · Fixed by #406
Labels
bug Something isn't working github_actions Pull requests that update GitHub Actions code

Comments

@AtomicFS
Copy link
Collaborator

Oh, I know now why it behaves the way it does. In examples it is not compiling the firmware-action binary, it is fetching it from releases on GitHub. But we had some breaking changes since.

Problem is that the example CI does not detect that firmware-action needs to be compiled in this instance. It detects if compilation is needed based on diff of action/ directory compared to main and not compared to latest release.

Originally posted by @AtomicFS in #410 (comment)

@AtomicFS AtomicFS added bug Something isn't working github_actions Pull requests that update GitHub Actions code labels Nov 14, 2024
@AtomicFS
Copy link
Collaborator Author

AtomicFS commented Nov 14, 2024

dorny/paths-filter has the option to change this, it is called base, but of course it is disabled on pull_request event because why wouldn't it be.

There is a closed issue about it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working github_actions Pull requests that update GitHub Actions code
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant