-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(cmd): change BuildCommand into slice #519
base: main
Are you sure you want to change the base?
Conversation
9558e59
to
72b9ef7
Compare
Failing because of
|
- this is a breaking change - this should make the JSON configuration files much more readable for edk2 - this change means we have to drop DefconfigPath for edk2 Signed-off-by: AtomicFS <[email protected]>
72b9ef7
to
6754103
Compare
Now when I am thinking about this, it is inconvenient that stuff like I don't know ... not sure if this is a good idea anymore. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So the removed DefconfigPath for EDK2 is now part of the BuildCommand field or how does that work in practice?
I did not know in which order the PR's will get merged ;) |
Oh sorry, I misread the comment. Yes, the general idea is to not use the I believe that it was meant to simplify local builds. If we would switch to However the issue is that |
DefconfigPath
for edk2fixes #518