Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

question: disable diagnostics window? #27

Closed
mpl opened this issue Dec 13, 2019 · 3 comments
Closed

question: disable diagnostics window? #27

mpl opened this issue Dec 13, 2019 · 3 comments
Labels
enhancement New feature or request

Comments

@mpl
Copy link

mpl commented Dec 13, 2019

Hello,

At the moment, the diagnostics window generates so many "false positives" that it has become completely useless to me. It's usually a wall of text where actually relevant errors are near-impossible to find. I don't know if it is a misconfiguration on my part, or incompatibilities with the project(s) I am working on, or a shortcoming of acme-lsp, but that's how it is for me.

Not only is it sad that it does not do anything useful for me anymore, but the actual problem is it has also become a nuisance because whenever I do Put on a window, the diagnostics window refreshes, and sometimes the mouse pointer even jumps to it.

I would like to keep on using acme-lsp, for "L def", and automatic formatting + imports, but I would like to get rid of the diagnostics window for now. Is it possible?

thanks.

@fhs
Copy link
Collaborator

fhs commented Dec 13, 2019

Diagnostics will always be sent by the LSP server but acme-lsp can hide it. I've also noticed bad diagnostics from gopls (e.g. when editing files for other runtime.GOOS). Things should improve as gopls becomes more stable.

I'm not sure we want to get rid of the diagnostics window entirely because we need to have at least one window open to support dump file (#15), but I can definitely add a flag to hide diagnostics. Sometimes it's useful to run tests with Watch go test, in which case you see diagnostics on two different windows.

@fhs fhs added the enhancement New feature or request label Dec 13, 2019
@mpl
Copy link
Author

mpl commented Dec 13, 2019

Diagnostics will always be sent by the LSP server but acme-lsp can hide it. I've also noticed bad diagnostics from gopls (e.g. when editing files for other runtime.GOOS). Things should improve as gopls becomes more stable.

I'm not sure we want to get rid of the diagnostics window entirely because we need to have at least one window open to support dump file (#15), but I can definitely add a flag to hide diagnostics. Sometimes it's useful to run tests with Watch go test, in which case you see diagnostics on two different windows.

Just to be clear, you're saying that when you use 'Watch go test', it would be convenient to be able to hide diagnostics, because it is redundant with the output that is in the "watch window", right?

@fhs fhs closed this as completed in f9edabb Dec 13, 2019
@fhs
Copy link
Collaborator

fhs commented Dec 13, 2019

Just to be clear, you're saying that when you use 'Watch go test', it would be convenient to be able to hide diagnostics, because it is redundant with the output that is in the "watch window", right?

Right. It might be worth adding support for dynamically enabling/disabling display of diagnostics, but for now I've added a -hidediag flag and a corresponding HideDiagnostics config value.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants