Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ASMARA says recently issued alert is very expired #37

Closed
miceoroni opened this issue Mar 3, 2024 · 16 comments · Fixed by #49
Closed

ASMARA says recently issued alert is very expired #37

miceoroni opened this issue Mar 3, 2024 · 16 comments · Fixed by #49
Assignees
Labels
bug Something isn't working

Comments

@miceoroni
Copy link

whenever any alert gets passed through the script, it says the alert is very expired. could anyone look into this and provide a solution? thanks! here is a log file to what I'm experiencing:
logthing.txt

@reggietorres
Copy link
Contributor

reggietorres commented Mar 3, 2024

Your alert needs to be from today's date, it won't send it if the alert has passed its expire time @miceoroni
unless there's a bug that we have not discovered, your issue is that the alert you have sent has already passed the expire time of 1 hour

Edit: incorrect info disregard

@miceoroni miceoroni reopened this Mar 3, 2024
@secludedhusky
Copy link

Due to it being a leap year, the program isn't able to calculate the "Very Expired" as well as "Too Early" values for some reason.

This is a genuine issue and it is an issue with the way the program calculates the time and date.

@reggietorres
Copy link
Contributor

reggietorres commented Mar 5, 2024

same here, i'm able to reproduce

[12:09:39E] > [DECODER] TRACELOG > startTime: 1709760960.0
[12:09:39E] > [DECODER] TRACELOG > endTime: 1709772660.0
[12:09:39E] > [DECODER] TRACELOG > now - S.T: -84381.0
[12:09:39E] > [DECODER] TRACELOG > now - E.T: -96081.0
[12:09:39E] > [DECODER] Monitor 1: Alert is Very Expired.

@physprop
Copy link
Collaborator

physprop commented Mar 6, 2024

It doesn't help that those start/end timestamps are from the future.

Keep in mind that epoch does not include leap seconds.

@A-c0rN should take a look at this.

@A-c0rN
Copy link
Owner

A-c0rN commented Mar 10, 2024

The code is designed to throw out alerts if it's greater than ~5 hours in the future, assuming that the alert was sent over a year ago.
This kinda failed because it assumed the alert was 1 day in advance. This isn't necessarily an issue with ASMARA, but the underlying libraries I use.

I'll look into workarounds, this issue has bit me in the ass too many times now lmao

@A-c0rN A-c0rN self-assigned this Mar 10, 2024
@A-c0rN A-c0rN added the bug Something isn't working label Mar 10, 2024
@ManMacho
Copy link

Im having this issue too :/

@ShowLowfinityHarvester
Copy link

me three

@ManMacho
Copy link

@A-c0rN I have found a fix to this, I'd love to share it with you through discord or something, if needed.

@reggietorres
Copy link
Contributor

@A-c0rN I have found a fix to this, I'd love to share it with you through discord or something, if needed.

If you have code, fork the project and send a pull request

If you don't but have an idea on how, write a three page essay on how (lol, just tell us how, include line numbers)

@WhoIsAsking1996
Copy link

@A-c0rN I have found a fix to this, I'd love to share it with you through discord or something, if needed.

If you have code, fork the project and send a pull request

If you don't but have an idea on how, write a three page essay on how (lol, just tell us how, include line numbers)

I have an idea for a fix but it has a risk to it

@WhoIsAsking1996
Copy link

still no fix 😭

@WhoIsAsking1996
Copy link

There is a hot fix on my github

@A-c0rN
Copy link
Owner

A-c0rN commented Jun 5, 2024

There is a hot fix on my github

Lol removing the code isn't a fix, it's covering up the underlying issue.

Sorry I haven't been available, It's that time of year.
Just started getting back into the project, and there's gonna be a massive code refactor coming.

and this one will be fun :3

@reggietorres
Copy link
Contributor

There is a hot fix on my github

Lol removing the code isn't a fix, it's covering up the underlying issue.

Yeah thats what I told him

@physprop
Copy link
Collaborator

I have this properly fixed in my personal repository. Made a pull request so we can merge it to the mainline.

@physprop physprop self-assigned this Jun 26, 2024
@physprop physprop linked a pull request Jun 26, 2024 that will close this issue
@reggietorres
Copy link
Contributor

I have this properly fixed in my personal repository. Made a pull request so we can merge it to the mainline.

Awesome, il take a look at it when I have time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

8 participants