Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unecessary multiple database requests when determining the release type #47

Open
TheMelmacian opened this issue Jul 30, 2021 · 0 comments

Comments

@TheMelmacian
Copy link
Contributor

TheMelmacian commented Jul 30, 2021

To determine the release type the script first makes a database request to get the GamePieceTypes,id and than inserts it in the sql script. It would be much more efficient if we just join the GamePieceTypes table to the MasterList and use the type name directly.

I already prepared a fix but I wanted to ask if it is okay if I also change the whole SQL to ISO/ANSI compliant joins?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant