Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix problems in 'view catalog' #31

Open
SieBRUM opened this issue Jun 3, 2021 · 0 comments
Open

Fix problems in 'view catalog' #31

SieBRUM opened this issue Jun 3, 2021 · 0 comments
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@SieBRUM
Copy link
Member

SieBRUM commented Jun 3, 2021

Add catalog tests

image
Keep pagination at bottom at all times

image
Images jump when changing

image
When screen is too small, the datapicker gets out of view

datepicker-unavailable is atm not well constructed (we discussed in discord), has a bug.
But the fact that this bug was not found during the creation of the unit tests actually says that the unit tests are not good / not pulled well enough. Try to apply only 1 change per test (so don't apply status EN requiresApproval in one test, for example, but really separate test for writing, and possibly another test where both change or something)

Also, ARCHIVED does not work. Would not eg not 'temporarily unavailable' but 'this product is permanently unavailable' or something, indicate that it will never be available again. (filed is miss not clear enough)

See SieBRUM/aci-frontend#30 for more information

@SieBRUM SieBRUM added bug Something isn't working good first issue Good for newcomers labels Jun 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

1 participant