From 818bb3d5b11e227b1dec1bd8020d0fcdc6a85198 Mon Sep 17 00:00:00 2001 From: nkwajudetambe Date: Tue, 11 Jun 2024 12:27:59 +0100 Subject: [PATCH] feat(backend): Update API endpoint to use phone number for balance checking --- .../repository/UserRepository.java | 4 +++- .../powerpaybackend/services/CheckBalance.java | 2 +- .../services/CheckBalanceController.java | 17 ++++++++--------- 3 files changed, 12 insertions(+), 11 deletions(-) diff --git a/power-pay-backend/src/main/java/com/adorsys/gis/powerpay/powerpaybackend/repository/UserRepository.java b/power-pay-backend/src/main/java/com/adorsys/gis/powerpay/powerpaybackend/repository/UserRepository.java index 4635a4aa..e26a3b01 100644 --- a/power-pay-backend/src/main/java/com/adorsys/gis/powerpay/powerpaybackend/repository/UserRepository.java +++ b/power-pay-backend/src/main/java/com/adorsys/gis/powerpay/powerpaybackend/repository/UserRepository.java @@ -9,5 +9,7 @@ @Repository public interface UserRepository extends JpaRepository { - Optional findByUserId(String userId); + //Optional findByUserId(String userId); + + Optional findByPhoneNumber(String phoneNumber); } diff --git a/power-pay-backend/src/main/java/com/adorsys/gis/powerpay/powerpaybackend/services/CheckBalance.java b/power-pay-backend/src/main/java/com/adorsys/gis/powerpay/powerpaybackend/services/CheckBalance.java index 8aa5e341..91bc0bfb 100644 --- a/power-pay-backend/src/main/java/com/adorsys/gis/powerpay/powerpaybackend/services/CheckBalance.java +++ b/power-pay-backend/src/main/java/com/adorsys/gis/powerpay/powerpaybackend/services/CheckBalance.java @@ -4,5 +4,5 @@ //implementing an empty interface public interface CheckBalance { - Double checkBalance(String userId) throws UsernameNotFoundException; + Double checkBalance(String phoneNumber) throws UsernameNotFoundException; } \ No newline at end of file diff --git a/power-pay-backend/src/main/java/com/adorsys/gis/powerpay/powerpaybackend/services/CheckBalanceController.java b/power-pay-backend/src/main/java/com/adorsys/gis/powerpay/powerpaybackend/services/CheckBalanceController.java index 54085a78..799eb533 100644 --- a/power-pay-backend/src/main/java/com/adorsys/gis/powerpay/powerpaybackend/services/CheckBalanceController.java +++ b/power-pay-backend/src/main/java/com/adorsys/gis/powerpay/powerpaybackend/services/CheckBalanceController.java @@ -25,17 +25,16 @@ public CheckBalanceController(CheckBalance checkBalanceService,UserRepository us this.userRepository = userRepository; } - @GetMapping("/{userId}") - public ResponseEntity checkBalance(@PathVariable String userId){ - Optional user = userRepository.findByUserId(userId); - if(user.isPresent()){ - Double balance = checkBalanceService.checkBalance(userId); - return ResponseEntity.ok("Balance for user ID" + " : " +balance); - } - else { + @GetMapping("/{phoneNumber}") + public ResponseEntity checkBalance(@PathVariable String phoneNumber) { + Optional user = userRepository.findByPhoneNumber(phoneNumber); + if (user.isPresent()) { + Double balance = checkBalanceService.checkBalance(phoneNumber); + return ResponseEntity.ok("Balance for user phoneNumber" + " : " + balance); + } else { return ResponseEntity.status(HttpStatus.NOT_FOUND).body("User not found"); } - } } +}