-
-
Notifications
You must be signed in to change notification settings - Fork 334
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
EventProcessor should not exist #2910
Comments
The problem I see here is that
This code is solely called from fuzzer/mod.rs in |
@domenukk |
Yes the evaluation doesn't have to be part of event manager. Sounds like we might even be able to give the event manager a callback of sorts that does the eval? A simple public fn might be an issue if someone wants to change the behavior in their own fuzzer |
We are trying to add EM, Z to the executors here #2873, which I think is a correct thing
Now the problem is that we have this code.
and this
Z: ExecutionProcessor<Self, I, E::Observers, S> + EvaluatorObservers<E, Self, I, S>,
is not letting me to compile things, if, for example, CentralizedEventManager is used. Because the fuzzer's EM is CentralizedEventManager, but this implementation'sSelf
isLlmpRestartingEventManager
so it won't compile.To me the biggest problem here is that EventProcessor defined on event manager. I think we should make this a public function...
and delete this EventProcessor trait.
The text was updated successfully, but these errors were encountered: