Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete simulation polygon #57

Closed
nickhorspool opened this issue Jun 22, 2011 · 9 comments
Closed

Delete simulation polygon #57

nickhorspool opened this issue Jun 22, 2011 · 9 comments

Comments

@nickhorspool
Copy link

Hi Andreas,

Another piece of feedback from the workshop was that if people made errors with the simulation polygon in step 2, there was no way for them to delete it and they had to restart the simulator app and start again which is pretty annoying for them.

Can you put in a way to delete the polygon, and also some people were able to draw two simulation polygons. this should not be allowed.

Cheers
NIck

@ghost ghost assigned ahocevar Jun 28, 2011
@ahocevar
Copy link
Contributor

So we are dealing with a bug and with a feature request here.

Regarding the bug where people are able to draw two simulation polygons, I need exact steps to reproduce it (I was not able to so far).

Regarding the feature request, would you prefer a Delete button in the "Draw or Import" row, or to delete a selected geometry by hitting "Del" when over a feature?

@nickhorspool
Copy link
Author

I think a delete button would be consistent with the other polygons so lets
go for that if you are happy with that.

I will try and reproduce the two polygon issue and.

Nick

On Thu, Jul 14, 2011 at 6:10 PM, ahocevar <
[email protected]>wrote:

So we are dealing with a bug and with a feature request here.

Regarding the bug where people are able to draw two simulation polygons, I
need exact steps to reproduce it (I was not able to so far).

Regarding the feature request, would you prefer a Delete button in the
"Draw or Import" row, or to delete a selected geometry by hitting "Del" when
over a feature?

Reply to this email directly or view it on GitHub:
#57 (comment)

@ghost ghost assigned bartvde Sep 19, 2011
@nickhorspool
Copy link
Author

As mentioned above, I would be happy with a delete button similar to what is available for the internal polygons.

@bartvde
Copy link

bartvde commented Sep 21, 2011

Just to clarify, will the delete button delete the simulation area with all its internal polygons, or just the simulation area itself?

@nickhorspool
Copy link
Author

Just the simulation area polygon. Not the internal polygons.
On 21 Sep 2011 19:54, "Bart van den Eijnden" <
[email protected]>
wrote:

Just to clarify, will the delete button delete the simulation area with
all its internal polygons, or just the simulation area itself?

Reply to this email directly or view it on GitHub:
#57 (comment)

bartvde pushed a commit that referenced this issue Sep 26, 2011
… improved, i.e. content is now too wide for panel (see #57)
@bartvde
Copy link

bartvde commented Sep 26, 2011

Nick, Jeff: how should we handle existing inner polygons? When digitizing the new simulation area they are not re-checked.

@bartvde
Copy link

bartvde commented Sep 26, 2011

AFAICT the client-side work for this issue has been done. Leaving the ticket open to get an answer to the above question.

@nickhorspool
Copy link
Author

You will need to recheck them because they may fall outside or partially
outside the sim polygon which is not allowed.
On 26 Sep 2011 18:05, "Bart van den Eijnden" <
[email protected]>
wrote:

Nick, Jeff: how should we handle existing inner polygons? When digitizing
the new simulation area they are not re-checked.

Reply to this email directly or view it on GitHub:
#57 (comment)

@bartvde
Copy link

bartvde commented Sep 26, 2011

Thanks for the clarification, I will recheck them in the client.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants