[Feature Request] FSB does not respect Iris-shader-modified day-cycle rotational offset

[coornio]

I mentioned this on discord as well, but if one uses a shaderpack through Iris which allows the day-cycle rotation to be angled differently than vanilla (say, 45 degrees to the side so it's diagonal), FSB will not respect it and operate on this new offset. It enforces its own fixed trajectories based on the vanilla day-cycle angle.

Here's an example shot where an Iris shader (Complementary) is enabled while FSB is active. The shader respects all skybox assets, but is unable to enforce its offset on them. As a result, the sunlight and rays are originating from the side of the sun:

I'd love it if something could be done so that the two would play nice with each other, thank you!

Related to #28

[supsm]

Duplicate of #28

Also I don't think this is very feasible, not only would it require accessing the zenith angle from iris (or other mods), it would also need to tilt the sun skybox specifically. If all the skyboxes were tilted, most of them would look slanted and weird, and there is no easy way to find out which skybox(es) are the sun/moon do they can be tilted.

I might be missing something though, if you have an idea of how this may be implemented please let me know

[coornio]

I mean, why would you tilt the skyboxes in general? Leave them be. All you'd want is a specific setting that you could enable in any config you want that would make FSB respect angle/tilt changes that Iris (or whatever) make and apply the maths that FSB already does on top of these offsets.

As for the exact method of insertion.. not entirely sure. I reckon you'd need to ask more details to the shader maker and whether FSB can access these values in the first place before deciding how to account for the offsets in the calculation.

In theory anyway... perhaps FSB could go the agnostic route instead. For example, instead of tying the two together and working at the same time.. ensure they stay completely separated and out of each other's way. To be specific:

A) Existing skybox setups and such will just operate as they are now and completely ignore any Iris/mod changes to the day/night cycle angle and tilt (we already do this more or less).
B) A dedicated setting could allow a particular skybox to be locked to the day/night cycle specifically, even if that's modified by something else (aka respecting the vanilla or modified angle/tilt). The only rotating allowed would be in-place (so still centered at the sun or moon, configurable).

Also I mentioned "related to #28" because there's already way more information and discussion on this matter here as opposed to the older ticket which has been buried :P

[supsm]

So the user would have to pick the sun/moon skyboxes manually? I think that might be too much work for the user and the dev (esp considering it would have to be done for every resourcepack)

[coornio]

So the user would have to pick the sun/moon skyboxes manually? I think that might be too much work for the user and the dev (esp considering it would have to be done for every resourcepack)

It already is a fair amount of work because the direct conversion is not sufficient to make optifine skies work the same in FSB, so that's a moot point. Adding a single extra line of config is hardly an effort.

[AMereBagatelle]

This is not currently on my radar to fix, especially since there are so many moving pieces to this problem. In order for this to properly be fixed to my knowledge both FSB and Iris, as well as the active shader and skybox, would all have to account for this happening. It's possible there's a simpler solution, but without a deep dive into Iris's code I don't know.

[RaptaG]

This should fixed from Iris' end now
https://github.com/IrisShaders/Iris/blame/1.18.2/docs/changelogs/1.6.0/full.md#L21

[FlashyReese]

It's not, I have discussed this on the Discord server.