Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove bundled pyqtgraph? #128

Closed
ojdf opened this issue Dec 13, 2022 · 1 comment
Closed

Remove bundled pyqtgraph? #128

ojdf opened this issue Dec 13, 2022 · 1 comment
Assignees

Comments

@ojdf
Copy link
Collaborator

ojdf commented Dec 13, 2022

The old version of pyqtgraph bundled with soapy is causing some problems, such as #121. I've encountered some other issues with python 3.10+ too. Should we remove the pyqtgraph bundled with soapy and add as a dependancy? I can't remember the reason for bundling it in the first place. Pyqtgraph is installable via pip and conda now which may not have been the case when originally developing the GUI.

If we don't remove it, it at least needs an update.

@andrewpaulreeves
Copy link
Collaborator

Yes, lets just add it as a requirement...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants