Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A method to solve PHYSICAL propagation problem in sci camera #142

Open
jsxiaxusheng opened this issue Oct 17, 2024 · 0 comments
Open

A method to solve PHYSICAL propagation problem in sci camera #142

jsxiaxusheng opened this issue Oct 17, 2024 · 0 comments

Comments

@jsxiaxusheng
Copy link

jsxiaxusheng commented Oct 17, 2024

In sh_8x8.yaml configuration, if using PHYSICAL in sci camera setting, the output detector PSF will be blank.

I found that that:

The returning variable of self.los.makePhase() method is efield, but the calcFocalPlane() function only use self.los.phase to calculate the intensity on the detector.

Therefore I suggest this change in SCI.py:

Line 99

self.interp_efield = numpy.zeros((self.FOVPxlNo, self.FOVPxlNo), CDTYPE)

Line 136-140

numbalib.bilinear_interp(
self.los.EField, self.interp_coords, self.interp_coords, self.interp_efield,
self.thread_pool, bounds_check=False)
self.EField_fov = self.interp_efield * self.scaledMask

I use this change solve the problem (but with no comlete testing).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant