-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BSA Test 835 "Check Function level reset" needs a PAL override to allow for shorter delay time for pre-silicon #419
Comments
Hi, Thanks for the query. PAL file need to be updated by partner only. please check anything can be handled here. yes, these tests should be in both BSA and SBSA. Thanks, |
This isn't a PAL file. The problematic code is here: test_pool/pcie/operating_system/test_os_p035.c (which the partner shouldn't update). Where ONE_MILLISECOND is defined here: Since a partner shouldn't update these files, we need a way to make it feasible for pre-silicon tests. Or should we not run these tests in pre-silicon? 100 ms is even a long time on an emulator! |
Hi, yes. Partner need not update "test_pool/pcie/operating_system/test_os_p035.c". Ex: Partner can implement multiplication factor to compensate delay it reduces the delay of all the tests uses "val_time_delay_ms" with the factor. we need to run these tests on pre-silicon. We have this test in BSA for Root port and End point devices and in SBSA for integrated devices(RCiEP and IEP_EP/ iEP_RP) Hope this solves your issue. Please let me know your feedback. Thanks, |
This solution works! Being able to update it with pal_time_delay_ms is exactly what I needed. Thanks! |
In pre-silicon, waiting 100 ms is a really long time and isn't necessary:
status = val_time_delay_ms(100 * ONE_MILLISECOND);
It would be awesome to be able to configure at the PAL layer so this is runnable on pre-silicon.
status = val_time_delay_ms( * ONE_MILLISECOND);
It should of course default to the 100.
Note: This is also true of SBSA Test 835. Are these tests different and should they be in both SBSA and BSA?
The text was updated successfully, but these errors were encountered: