Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

USING LINK IN NEXTJS #44

Open
ErnestDaDev opened this issue Jun 11, 2022 · 5 comments
Open

USING LINK IN NEXTJS #44

ErnestDaDev opened this issue Jun 11, 2022 · 5 comments
Labels
bug Something isn't working

Comments

@ErnestDaDev
Copy link
Contributor

ErnestDaDev commented Jun 11, 2022

Nice package. There seems to be an issue with the menu closing on mobile devices. I have the responsive menu in a global layout using NextJS so when it switches to mobile and you tap a menu item, it does not close up the menu.

@Abusayid693
Copy link
Owner

@ErnestDaDev Thanks for reporting, will fix it ASAP

@Abusayid693 Abusayid693 added the bug Something isn't working label Jun 11, 2022
@Abusayid693 Abusayid693 reopened this Jun 11, 2022
@Abusayid693
Copy link
Owner

@ErnestDaDev This is not a bug wrap Navigation component on each page or route instead of global layout.

@ErnestDaDev
Copy link
Contributor Author

ErnestDaDev commented Jun 11, 2022

@ErnestDaDev This is not a bug wrap Navigation component on each page or route instead of global layout.

Yeah. That fixes it. But check after deploying to the cloud the disadvantage is when the page is loading, it displays a blank screen, which of course can be replaced with a loader but it's overkill simply because of a navbar. You can provide an option to provide a state to handle the toggle and animate down of the menu items.
error

@Abusayid693
Copy link
Owner

Abusayid693 commented Jun 11, 2022

Yeah. That fixes it. But check after deploying to the cloud the disadvantage is when the page is loading, it displays a blank ...

Yes this seems like problematic from user experience perspective, I will add a prop to handle the state manually, feel free to open any PR for this fix

@ErnestDaDev
Copy link
Contributor Author

Yeah. That fixes it. But check after deploying to the cloud the disadvantage is when the page is loading, it displays a blank ...

Yes this seems like problematic from user experience perspective, I will add a prop to handle the state manually, feel free to open any PR for this fix

Yes, created one. Kindly check it out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants