Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Addition TIME1899() doc updates #33

Open
clach04 opened this issue Sep 1, 2023 · 0 comments
Open

Addition TIME1899() doc updates #33

clach04 opened this issue Sep 1, 2023 · 0 comments

Comments

@clach04
Copy link
Member

clach04 commented Sep 1, 2023 •
edited
Loading

Follow on from #32 - comment #32 (comment)

Requested Change 1

The explanation you have in the merge description is worth placing in code comments (i.e. XML comments), including the link to https://github.com/tableau/connector-plugin-sdk/blob/4cbc26c6c358224774cb8e5371f6b5292dbe531c/samples/components/dialects/SQLDialect.tdd#L51C38-L51C38

Requested Change 2

I want to see more information/explanation about why our implementation is returning time rather than datetime and why it is not using the magic date of 1899-12-30. My reading was that Tableau doesn't have a proper time datatype based on the explanation, I'm wondering if perhaps this is a workaround Tableau has for DBMS that don't have time only?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@clach04