Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve hide-in-shadow-dom scriptlet to support >>> and ExtCSS #474

Open
piquark6046 opened this issue Jan 15, 2025 · 1 comment
Open

Improve hide-in-shadow-dom scriptlet to support >>> and ExtCSS #474

piquark6046 opened this issue Jan 15, 2025 · 1 comment
Assignees

Comments

@piquark6046
Copy link
Member

AdguardTeam/AdguardFilters#195191

To improve targeting an element, I think that we need to support >>> syntax of trusted-click-element and Extended CSS to hide-in-shadow-dom scriptlet.

Screenshot

image

@AdamWr
Copy link
Member

AdamWr commented Jan 15, 2025

I think that for apps.microsoft.com case we can use rather safely a rule like this:

apps.microsoft.com#%#//scriptlet('hide-in-shadow-dom', 'buy-box[telemetry-area-id="CtaButton"][telemetry-data*="buttonType"][telemetry-data*="share"]')

It hides "Share" button (it seems that it's not displayed on Windows, so changing user-agent might be required) and it doesn't hide a download button.

But of course improving the scriptlet might be useful.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants