Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adyen::Client#service_base_url logic is incorrect making the DisputesAPI unusable #283

Open
timnovinger opened this issue Dec 16, 2024 · 0 comments

Comments

@timnovinger
Copy link

Describe the bug
When the DisputesAPI portion of the client gem was updated (it appears around version 8) to use disputes instead of dispute it broke the logic in the service_url_base method due to the Adyen::Service::Disputes class using "Disputes" as the service variable instead of "DisputeService".

https://github.com/Adyen/adyen-ruby-api-library/blob/v10.1.0/lib/adyen/client.rb#L72
https://github.com/Adyen/adyen-ruby-api-library/blob/v10.1.0/lib/adyen/services/disputes.rb#L13

How to reproduce
Attempt to use any of methods within the Adyen::Service::Disputes class and you will met with an Invalid service specified error.

Expected behavior
A successful request.

Screenshots
N/A

Desktop (please complete the following information):

  • ruby Version: ruby 3.0.1p64 (2021-04-05 revision 0fb782ee38) [x86_64-linux]
  • Library Version: 10.1.0

Additional context
Add any other context about the problem here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant