Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No vstorage paths for several PSM assets on Emerynet + Devnet #10157

Open
otoole-brendan opened this issue Sep 25, 2024 · 2 comments
Open

No vstorage paths for several PSM assets on Emerynet + Devnet #10157

otoole-brendan opened this issue Sep 25, 2024 · 2 comments
Labels
bug Something isn't working

Comments

@otoole-brendan
Copy link
Contributor

Describe the bug

Whilst carrying out some manual Econ Gov UI tests for Upgrade 17 on Emerynet - I discovered some 'no data for vstorage path' errors (see screenshot) for 5 of the PSM assets including USDC, USDC_grv, USDT_grv, USDT_axl and AUSD. The error is thrown when I select 'Proposal Type = Parameter Change' under 'PSM' tab.

When I check vstorage viewer, I can confirm I don't see those 5 assets listed so the error checks out.

The concern is - these were assets that were added to the PSM in the past so why have they dropped out of vstorage all of a sudden? It's currently making them ungovernable as the EC user can't configure changes for them. Were they reverted somewhere along the way? Is there a risk that this happens in Mainnet triggered by upgrade 17?

This is also occurring on Devnet (although for a different subset of assets including ToyUSD, DAI_axl, DAI_grv, USDC and USDT) which is running upgrade 16 so it doesn't appear to relate to upgrade 17 in particular.

image

On Emerynet vstroage viewer -> 5 assets with visible vstorage paths https://toliaqat.github.io/vstorage/?path=published.psm.IST&endpoint=https%3A%2F%2Femerynet.rpc.agoric.net%3A443

Screenshot of Econ Gov UI throwing 'no path' error for the 5 missing assets:
image

To Reproduce

Steps to reproduce the behavior:

  1. Go to ...' or https://econ-gov.inter.trade/?agoricNet=devnet as Gov 1, 2 or 3
  2. Click on 'PSM' tab
  3. Cycle through assets
  4. See error

Expected behavior

These assets should have vstorage paths. They weren't removed as supported PSM assets and should persist.

@otoole-brendan otoole-brendan added the bug Something isn't working label Sep 25, 2024
@samsiegart
Copy link
Contributor

In Agoric/dapp-econ-gov#130 we added some error toasts in cases where things previously were silently erroring in the console. So this error toast about the missing vstorage path is being seen now for the first time, it used to just say loading and never load. The UI hardcodes all the PSM paths like AUSD, ToyUSD, USDC_axl etc. and tries to query them when selected, so if they don't exist on the current chain then you see this error.

For as long as I can remember, not all assets have been supported by all networks. However, I wouldn't be able to prove to you which ones. I'm willing to guess that we're just noticing this for the first time because of the error toast, but there's nothing actually missing that wasn't before.

@dckc
Copy link
Member

dckc commented Sep 25, 2024

... The UI hardcodes all the PSM paths like AUSD, ToyUSD, USDC_axl etc.

Yeah... known issue:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants