Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

clarify that offer give/want are "at most" and "at least" #1227

Open
dckc opened this issue Oct 2, 2024 · 1 comment
Open

clarify that offer give/want are "at most" and "at least" #1227

dckc opened this issue Oct 2, 2024 · 1 comment

Comments

@dckc
Copy link
Member

dckc commented Oct 2, 2024

Definition: Offer safety means that the user is guaranteed to either get what they wanted

It's not clear that the way it actually works is that they're guaranteed to get what they wanted or more.

That is: AmountMath.isGTE.

cc @tgrecojs
@dckc
Copy link
Member Author

dckc commented Oct 2, 2024

Jorge reminds us of an office hours session where MarkM joined to talk about offer patterns (IOU link).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@dckc