-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
stop deep imports of agoric CLI package #112
Comments
turadg
added a commit
to Agoric/agoric-sdk
that referenced
this issue
Jun 22, 2023
That one is gonna be tricky. If we rely on the CLI, we should add a CLI command to get the path of the binaries. cc @michaelfig, any thoughts? I know you've been thinking about build artifacts, and this is somewhat relevant. |
turadg
added a commit
to Agoric/agoric-sdk
that referenced
this issue
Jun 22, 2023
mhofman
pushed a commit
to Agoric/agoric-sdk
that referenced
this issue
Aug 7, 2023
anilhelvaci
pushed a commit
to anilhelvaci/agoric-sdk
that referenced
this issue
Aug 16, 2023
mhofman
pushed a commit
to Agoric/agoric-sdk
that referenced
this issue
Dec 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Agoric/agoric-sdk#7824 attempted to remove exports from the
agoric
package so that it's only used for itsbin
install.That broke loadgen CI,
For now I've restored the two exports loadgen expects,
testnet-load-generator/runner/lib/main.js
Lines 165 to 167 in 0e2b891
A more maintainable solution would be for the interface between loadgen and the
agoric
package to use the CLI.The text was updated successfully, but these errors were encountered: