Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stop deep imports of agoric CLI package #112

Open
turadg opened this issue Jun 22, 2023 · 1 comment
Open

stop deep imports of agoric CLI package #112

turadg opened this issue Jun 22, 2023 · 1 comment

Comments

@turadg
Copy link
Member

turadg commented Jun 22, 2023

Agoric/agoric-sdk#7824 attempted to remove exports from the agoric package so that it's only used for its bin install.

That broke loadgen CI,

(Error#1)
Error#1: Package subpath './lib/helpers.js' is not defined by "exports" in /usr/src/testnet-load-generator/runner/node_modules/agoric/package.json

  at resolve (file:///usr/src/testnet-load-generator/runner/lib/helpers/module.js:26:32)
  at getSDKBinaries (file:///usr/src/testnet-load-generator/runner/lib/main.js:172:33)
  at async Promise.all (index 0)
  at async main (file:///usr/src/testnet-load-generator/runner/lib/main.js:329:49)

For now I've restored the two exports loadgen expects,

const srcHelpers = 'agoric/src/helpers.js';
const libHelpers = 'agoric/lib/helpers.js';
try {

A more maintainable solution would be for the interface between loadgen and the agoric package to use the CLI.

turadg added a commit to Agoric/agoric-sdk that referenced this issue Jun 22, 2023
@mhofman
Copy link
Member

mhofman commented Jun 22, 2023

That one is gonna be tricky. If we rely on the CLI, we should add a CLI command to get the path of the binaries.

cc @michaelfig, any thoughts? I know you've been thinking about build artifacts, and this is somewhat relevant.

turadg added a commit to Agoric/agoric-sdk that referenced this issue Jun 22, 2023
mhofman pushed a commit to Agoric/agoric-sdk that referenced this issue Aug 7, 2023
anilhelvaci pushed a commit to anilhelvaci/agoric-sdk that referenced this issue Aug 16, 2023
mhofman pushed a commit to Agoric/agoric-sdk that referenced this issue Dec 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants