Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

@agoric/rpc (batchQuery, chainStorageWatcher) support for node.js #47

Open
2 tasks
0xpatrickdev opened this issue Sep 13, 2023 · 0 comments
Open
2 tasks

@agoric/rpc (batchQuery, chainStorageWatcher) support for node.js #47

0xpatrickdev opened this issue Sep 13, 2023 · 0 comments
Labels
enhancement New feature or request

Comments

@0xpatrickdev
Copy link
Member

0xpatrickdev commented Sep 13, 2023 •
edited
Loading

What is the Problem Being Solved?

batchQuery and chainStorageWatcher support for Node.js server environment in @agoric/rpc.

Description of the Design

  1. There are currently two references to window in the @agoric/rpc package:
  • window.setTimeout, window.clearTimeout
  • window.atob()
  • window.btoa() (testing only)
  1. Additionally, there are dependencies on window.keplr. Logic for setting up a wallet/signer should be separate from makeInteractiveSigner.js and walletConnection.js, so other wallets like DirectSecp256k1HdWallet can be supported.

Security Considerations

Scaling Considerations

I recognize this repository is named ui-kit, so I'm not sure it's the best place for these changes. However, the changes are so trivial that I think they make sense to land here.

Test Plan
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@0xpatrickdev