Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add message for failed unittests. #35

Closed
Agrover112 opened this issue Oct 16, 2021 · 12 comments
Closed

Add message for failed unittests. #35

Agrover112 opened this issue Oct 16, 2021 · 12 comments

Comments

@Agrover112
Copy link
Owner

Agrover112 commented Oct 16, 2021

A message indicating a failure for each unit-test, should give the user a small idea of what went wrong in the test.
ex:
self.assertEqual ( f(values), 0, msg ='HEURISTIC MESSAGE INDICATING WHY TEST CASE FAILED')

@Yoda-Canada
Copy link
Contributor

can I work on this issue?

@Agrover112
Copy link
Owner Author

can I work on this issue?

Sure !

@Yoda-Canada
Copy link
Contributor

@Agrover112 I run the example1.py, and the terminal cannot find the flights.txt. I checked the flights.txt and it had been saved in the data folder. Could you help me ?
1634600630(1)

@Agrover112
Copy link
Owner Author

@Agrover112 I run the example1.py, and the terminal cannot find the flights.txt. I checked the flights.txt and it had been saved in the data folder. Could you help me ?
1634600630(1)

Sure.

@Agrover112
Copy link
Owner Author

@Yoda-Canada It's in the README.md in getting started! as link

@Yoda-Canada
Copy link
Contributor

Yoda-Canada commented Oct 18, 2021

I have already done all steps which are in getting started, but the terminal cannot find it.

1634601434(1)

@Yoda-Canada
Copy link
Contributor

@Agrover112 , It's ready to run, thx.

@Yoda-Canada
Copy link
Contributor

Yoda-Canada commented Oct 19, 2021

@Agrover112 Question 1: I want to make sure that only these three files (test_algorithms.py, test_chaining.py, test_fitness.py) are needed to add error messages, right?
1634660682(1)
Question 2: There are only "self.assertEqual()" and "self.assertIsNotNone()" in the test files. "self.assertIsNotNone()" already has error message in it's definition. Do I just need to add error message to "self.assertEqual()"?
1634661217(1)

@Yoda-Canada Refer your master branch I made some changes there.

@Agrover112
Copy link
Owner Author

@Yoda-Canada So I raised a PR to YOUR fork. Accept that PR and make further changes.
Also do this asap, since I do not want your fork to fall behind the master branch again :(
Also maybe if interested at a later date you could check out #42 (similar but might take up huge amount of time on hold for rn)

@Yoda-Canada
Copy link
Contributor

@Yoda-Canada So I raised a PR to YOUR fork. Accept that PR and make further changes. Also do this asap, since I do not want your fork to fall behind the master branch again :( Also maybe if interested at a later date you could check out #42 (similar but might take up huge amount of time on hold for rn)

@Agrover112 no worry I will do it ASAP.

@Agrover112
Copy link
Owner Author

@Yoda-Canada So I raised a PR to YOUR fork. Accept that PR and make further changes. Also do this asap, since I do not want your fork to fall behind the master branch again :( Also maybe if interested at a later date you could check out #42 (similar but might take up huge amount of time on hold for rn)

@Agrover112 no worry I will do it ASAP.

I'm awake for your bro :)

@Yoda-Canada
Copy link
Contributor

@Agrover112 I have created a PR 48, please review it, thx.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants