Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ENHANCEMENT] Add #define guards to run_dynamics_fast #11

Open
aweinert-MIT opened this issue Mar 11, 2022 · 0 comments
Open

[ENHANCEMENT] Add #define guards to run_dynamics_fast #11

aweinert-MIT opened this issue Mar 11, 2022 · 0 comments
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed

Comments

@aweinert-MIT
Copy link
Member

Relation

The MATLAB mex function, run_dynamics_fast is used by multiple repositories, including em-model-manned-bayes to simulate aircraft trajectories with a 6DOF physics model. There are various #define statements that are unguarded.

Description

Add #define guards to prevent multiple inclusions.

Alternatives

#define guards are a good best practice and should be implemented.

Additional

Recommend addressing issue #10 for the use const variables before addressing this issue.

While the contributing guidelines does not define a style guide for C++, we currently recommend the Google C++ Style Guide for this issue.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@aweinert-MIT