From 5da8ca8ab6a01f2a02f09bffed534f6a52c7a83c Mon Sep 17 00:00:00 2001 From: libretto Date: Wed, 10 Jan 2024 16:07:49 +0200 Subject: [PATCH] fixup metrics stats usage --- karapace/metrics.py | 10 +++++++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/karapace/metrics.py b/karapace/metrics.py index 99a4c6366..ac0f52e3d 100644 --- a/karapace/metrics.py +++ b/karapace/metrics.py @@ -40,6 +40,8 @@ def __init__( ) -> None: self.is_ready = False self.lock = threading.Lock() + self.request_size_total = 0 + self.request_count = 0 def setup(self, config: Config) -> None: with self.lock: @@ -62,14 +64,16 @@ def request(self, size: int) -> None: return if not isinstance(self.stats_client, StatsClient): raise RuntimeError("no StatsClient available") - self.stats_client.gauge("request-size", size) + self.stats_client.increase("request-size-total", size) + self.stats_client.increase("request-count", 1) def response(self, size: int) -> None: if not self.is_ready or self.stats_client is None: return if not isinstance(self.stats_client, StatsClient): raise RuntimeError("no StatsClient available") - self.stats_client.gauge("response-size", size) + self.stats_client.increase("response-size-total", size) + self.stats_client.increase("response-count", 1) def are_we_master(self, is_master: bool) -> None: if not self.is_ready or self.stats_client is None: @@ -90,7 +94,7 @@ def error(self) -> None: return if not isinstance(self.stats_client, StatsClient): raise RuntimeError("no StatsClient available") - self.stats_client.increase("error_total", 1) + self.stats_client.increase("error-total", 1) def cleanup(self) -> None: if self.stats_client: