Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add feature display track length in an album #397

Conversation

tungnk123
Copy link
Contributor

No description provided.

@nift4 nift4 self-assigned this Feb 15, 2025
@nift4
Copy link
Collaborator

nift4 commented Feb 15, 2025

CI is failing, can you rebase your branch?

@tungnk123
Copy link
Contributor Author

Ok CI is completed

@nift4
Copy link
Collaborator

nift4 commented Feb 16, 2025

I spent some time testing this, however, the text disappears when using large font sizes in Android settings.
<LinearLayout
android:id="@+id/linearLayout"
android:layout_width="0dp"
android:layout_height="@dimen/grid_card_label_height"
the parent LinearLayout has an hardcoded height which is needed for fast scroll computation and that seems to be insufficient if there is a third line of text

@tungnk123
Copy link
Contributor Author

Could you pls suggest me some solution ?

@nift4
Copy link
Collaborator

nift4 commented Feb 16, 2025

maybe increasing grid_card_label_height, but I'm really not sure atm

nift4 and others added 10 commits February 16, 2025 10:01
Currently translated at 99.3% (293 of 295 strings)

Translation: Gramophone/App
Translate-URL: https://hosted.weblate.org/projects/gramophone/strings-xml/ja/
Currently translated at 100.0% (295 of 295 strings)

Translation: Gramophone/App
Translate-URL: https://hosted.weblate.org/projects/gramophone/strings-xml/uk/
Currently translated at 100.0% (295 of 295 strings)

Translation: Gramophone/App
Translate-URL: https://hosted.weblate.org/projects/gramophone/strings-xml/pl/
Currently translated at 100.0% (295 of 295 strings)

Translation: Gramophone/App
Translate-URL: https://hosted.weblate.org/projects/gramophone/strings-xml/ca/
@tungnk123
Copy link
Contributor Author

I increased grid_card_label_height and decreased text size a little bit. May be it works ^^

@tungnk123 tungnk123 closed this Feb 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants