Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

About release artifact name scheme #278

Open
Ra2-IFV opened this issue Sep 21, 2024 · 11 comments
Open

About release artifact name scheme #278

Ra2-IFV opened this issue Sep 21, 2024 · 11 comments

Comments

@Ra2-IFV
Copy link

Ra2-IFV commented Sep 21, 2024

I'm using scoop, a package manager for Windows, I wrote manifests for Thorium. I enjoy it so much.
I'm have problems automating getting recent releases.
In previous releases, I obtain version from tag_name, filter it with regex, here's example:

key value
tag_name M126.0.6478.231
regex M([\\d.-]+)
version 126.0.6478.231
url https://github.com/Alex313031/Thorium-Win/releases/download/M$version/Thorium_AVX_$version.zip
actual url https://github.com/Alex313031/Thorium-Win/releases/download/M$version/Thorium_AVX_126.0.6478.231.zip

And now, it's, TOTALLY BROKEN because the artifact names becomes so *CENSORED* strange just like thorium_Th24_BETA2_126.0.6478.251.zip
just wondering wtf is this why doing this, now there is no easy way to use the autoupdate feature so I have to update version manually
I don't know if you would change the pretty random naming rule, like using [Semantic Versioning](https://semver.org/), if not simply close this issue

@Ra2-IFV Ra2-IFV changed the title Begging you for not changing release artifacts so wildly Begging you for not changing release artifacts name so wildly Sep 21, 2024
@gz83
Copy link
Collaborator

gz83 commented Sep 22, 2024

I'm not sure why you define this as "wildly"? th24 is our recent work to fix some issues with the cr23 style, and there may continue to be versions marked as th24-beta until we consider th24 to be stable.

If you don't care about some of the issues with the cr23 style, you can completely ignore these th24-beta versions

@Ra2-IFV
Copy link
Author

Ra2-IFV commented Sep 22, 2024

I mean, the release file, naming rule, is wild
Doen't follow any naming rules I know so far
Also so inconvenient as no other fields matching it in Github API
The project is so fucking great, runs blazing fast, no errors, but I'm really not satisfied with the *release file name*.

@gz83
Copy link
Collaborator

gz83 commented Sep 22, 2024

If you feel this is not good enough, do you have a better naming scheme for this situation?

@Ra2-IFV
Copy link
Author

Ra2-IFV commented Sep 22, 2024

following previous naming syntax is enough; I also mentioned Semantic Versioning

@Ra2-IFV
Copy link
Author

Ra2-IFV commented Sep 22, 2024

This should be harmless since I'm not asking to change branch or tag names, or the release *title*.
If the project is using CI building, it's also a good practice.

@gz83
Copy link
Collaborator

gz83 commented Sep 22, 2024

The th24-beta version may still not use the previous naming scheme. As for semantic versioning, I will discuss it with Alex.

@gz83
Copy link
Collaborator

gz83 commented Sep 22, 2024

Also, Alex and I don't care about GitHub CI, which doesn't help much for the Thorium project.

https://github.com/Alex313031/thorium/blob/main/docs/FAQ.md

@Ra2-IFV
Copy link
Author

Ra2-IFV commented Sep 22, 2024

Then how do you build releases? in my case CI is really helpful when building things, I can take a break while it's running xD

@gz83
Copy link
Collaborator

gz83 commented Sep 22, 2024

The windows version of Thorium is basically compiled by me on my windows or linux machine, without using GitHub CI.

GitHub CI is not really suitable for compiling a large project like Chromium.

@Ra2-IFV
Copy link
Author

Ra2-IFV commented Sep 22, 2024

I'm quite annoyed stucking at old version and drank an overdose of coffee, causing Tachycardia and headache, so very for being emotional and impolite :(

@Ra2-IFV
Copy link
Author

Ra2-IFV commented Sep 22, 2024

Agree. so slow and difficult to solve building errors.
Thanks again for creating this project.

@Ra2-IFV Ra2-IFV changed the title Begging you for not changing release artifacts name so wildly About release artifact name scheme Sep 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants