-
-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
About release artifact name scheme #278
Comments
I'm not sure why you define this as "wildly"? th24 is our recent work to fix some issues with the cr23 style, and there may continue to be versions marked as th24-beta until we consider th24 to be stable. If you don't care about some of the issues with the cr23 style, you can completely ignore these th24-beta versions |
I mean, the release file, naming rule, is wild |
If you feel this is not good enough, do you have a better naming scheme for this situation? |
following previous naming syntax is enough; I also mentioned Semantic Versioning |
This should be harmless since I'm not asking to change branch or tag names, or the release *title*. |
The th24-beta version may still not use the previous naming scheme. As for semantic versioning, I will discuss it with Alex. |
Also, Alex and I don't care about GitHub CI, which doesn't help much for the Thorium project. |
Then how do you build releases? in my case CI is really helpful when building things, I can take a break while it's running xD |
The windows version of Thorium is basically compiled by me on my windows or linux machine, without using GitHub CI. GitHub CI is not really suitable for compiling a large project like Chromium. |
I'm quite annoyed stucking at old version and drank an overdose of coffee, causing Tachycardia and headache, so very for being emotional and impolite :( |
Agree. so slow and difficult to solve building errors. |
I'm using scoop, a package manager for Windows, I wrote manifests for Thorium. I enjoy it so much.
I'm have problems automating getting recent releases.
In previous releases, I obtain
version
fromtag_name
, filter it withregex
, here's example:tag_name
M126.0.6478.231
regex
M([\\d.-]+)
version
126.0.6478.231
url
And now, it's, TOTALLY BROKEN because the artifact names becomes so *CENSORED* strange just like
thorium_Th24_BETA2_126.0.6478.251.zip
just wondering wtf is this why doing this, now there is no easy way to use the
autoupdate
feature so I have to update version manuallyI don't know if you would change the pretty random naming rule, like using
[Semantic Versioning](https://semver.org/)
, if not simply close this issueThe text was updated successfully, but these errors were encountered: