Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Follow scala file naming conventions #4

Open
AlexITC opened this issue Feb 3, 2018 · 3 comments
Open

Follow scala file naming conventions #4

AlexITC opened this issue Feb 3, 2018 · 3 comments
Labels
alerts-server Changes required on the alerts-server project good first issue Hacktoberfest

Comments

@AlexITC
Copy link
Owner

AlexITC commented Feb 3, 2018

We are not following naming conventions on files containing multiple classes.

Expected behavior

Follow file naming conventions from: https://docs.scala-lang.org/style/files.html

Actual behavior

Files containing more than one class should be follow the camelCase style, most files from the models package need to be renamed.

@AlexITC
Copy link
Owner Author

AlexITC commented Oct 1, 2018

It is ok to submit a PR per file change.

@tg44
Copy link
Contributor

tg44 commented Oct 2, 2018

Hy!
Can I do a general refactor on the repo?
This "one file one name" thing is a global problem as I saw. (Not just in the models, but in the data dir too; so I assume there are more thing I could rearrange a bit :D )

@AlexITC
Copy link
Owner Author

AlexITC commented Oct 2, 2018

@tg44 Any improvement is welcome.

@AlexITC AlexITC added alerts-server Changes required on the alerts-server project and removed enhancement labels Oct 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
alerts-server Changes required on the alerts-server project good first issue Hacktoberfest
Projects
None yet
Development

No branches or pull requests

2 participants