New property (oneOf) in route permission object

[dmielewczyk]

I'm submitting a...

[ ] Regression (a behavior that used to work and stopped working in a new release)
[ ] Bug report  
[x] Feature request
[ ] Documentation issue or request

Current behavior

Currently there is no property in permissions object to handle a case when we need to allow access user with PERMISSION_1 or PERMISSION_2.

Expected behavior

I would expect new property oneOf that will check if user has one of listed permissions. This property should work with other properties as well (only, except).

Example:

{
    path: 'test',
    component: TestComponent,
    canActivate: [NgxPermissionsGuard],
    data: {
      permissions: {
        only: 'POST_WRITER',
        oneOf: ['MODERATOR', 'REPORTER']
      }
    }
 }

NgxPermissionGuard should check it in following way: permissions.has('POST_WRITER') && (permissions.has('MODERATOR') || permissions.has('REPORTER'))

[AlexKhymenko]

Hi. @dmielewczyk You can acchive this by creating Your custom permission

this.ngxPermissionsService.addPermission(
	"SPECIAL_PERMISSIONS",
	(permissionName, permissionsObject) => {
		return permissionsObject["POST_WRITER"] && (permissionsObject["MODERATOR"] || permissionsObject['REPORTER']);
		
	}
);

And then use it in guard

[dmielewczyk]

@AlexKhymenko thanks for the fast answer and proposed solution. Adding custom permission is a great feature that seems to be the cure for many problems. However I'm not a fan of mutating (in this case creating special permissions just for frontend purposes) and for me it would be great to handle it on route object definition level (that's more transparent).

If you would need some help with providing the solution I'm open to contribute.

[AlexKhymenko]

You can create this functionality if You want. This is open project. :-)