Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing dependency on iconv #3

Open
CharlesOkwuagwu opened this issue Aug 8, 2017 · 4 comments
Open

Removing dependency on iconv #3

CharlesOkwuagwu opened this issue Aug 8, 2017 · 4 comments

Comments

@CharlesOkwuagwu
Copy link
Contributor

CharlesOkwuagwu commented Aug 8, 2017

Hi @AlexKovalevych

Would you be interested in removing the dependency on the iconv library, it's a pain to get it to build on windows, and besides it seems you only really need it for UTF-16LE to UTF-8 conversion, which can be handled directly by the built-in :unicode module.

I can send a PR to that effect.

Regards.

@AlexKovalevych
Copy link
Owner

It would be nice to remove that dependency, but its used not only for UTF-16LE to UTF-8 conversion, e.g. https://github.com/AlexKovalevych/exoffice/blob/master/lib/exoffice/parser/excel_2003/string.ex#L72

Despite that, you can make a PR and we can test it with different cases to make sure algorithm will still work.

@CharlesOkwuagwu
Copy link
Contributor Author

CharlesOkwuagwu commented Aug 8, 2017

I have a fork of this here: https://github.com/CharlesOkwuagwu/exoffice

@CharlesOkwuagwu
Copy link
Contributor Author

CharlesOkwuagwu commented Jun 27, 2018

Have you looked at this yet?

@rockneurotiko
Copy link
Contributor

Maybe iconv can be changed for this one that is written in pure elixir:

https://github.com/tallakt/codepagex

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants