-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Removing dependency on iconv
#3
Comments
It would be nice to remove that dependency, but its used not only for UTF-16LE to UTF-8 conversion, e.g. https://github.com/AlexKovalevych/exoffice/blob/master/lib/exoffice/parser/excel_2003/string.ex#L72 Despite that, you can make a PR and we can test it with different cases to make sure algorithm will still work. |
I have a fork of this here: https://github.com/CharlesOkwuagwu/exoffice |
Have you looked at this yet? |
Maybe |
Hi @AlexKovalevych
Would you be interested in removing the dependency on the
iconv
library, it's a pain to get it to build on windows, and besides it seems you only really need it for UTF-16LE to UTF-8 conversion, which can be handled directly by the built-in:unicode
module.I can send a PR to that effect.
Regards.
The text was updated successfully, but these errors were encountered: