Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changed UI of suggested_coding_site.html #551

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Changed UI of suggested_coding_site.html #551

wants to merge 4 commits into from

Conversation

abhiraj-ku
Copy link

@abhiraj-ku abhiraj-ku commented Dec 15, 2022 •
edited by harikesh409
Loading

Description

Best and Free Online Websites to Learn Coding for Beginners was not looking good as all the text was in long paragraph style
and also the background gradient colors were not complementary so it not visible also ..

Please include a summary of the change and which issue is fixed.
Fixes #550
The changes made are that the paragraph style text is been changed into responsive cards design made Flex-box and CSS only

List any dependencies that are required for this change

No , Dependencies were required just pure CSS was applied

Type of change

Enhancement of suggested_coding_site.html

How Has This Been Tested?

With the help of developer tools

UI /UX changes

Attach gif or screenshot for changes.

  • Before :
    before ui
- After :

after ui

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@abhiraj-ku
Copy link
Author

hey @harikesh409 I have made a PR regarding the enhancement .waiting for your reply

harikesh409
harikesh409 requested changes Dec 15, 2022
View reviewed changes
Copy link
Collaborator

@harikesh409 harikesh409 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where are the images being used?

@harikesh409
Copy link
Collaborator

image

The contact us and the copyright footer is messed up.

@abhiraj-ku
Copy link
Author

The contact us and the copyright footer is messed up.

its done ..

footer

@abhiraj-ku
Copy link
Author

Added the images and also changed the name of images folder to suggested-sites

new bg

@harikesh409
Copy link
Collaborator

image

The main content is not proper now.

@abhiraj-ku
Copy link
Author

I have applied the changes you suggested and its working fine on local machine . i have pushed them also so that you can see the changes

@harikesh409
Copy link
Collaborator

image

check for this resolution, the responsive is not proper.

@abhiraj-ku
Copy link
Author

Hey actually i don't have monitor of this size so i made keeping in mind of the laptops and mobile screen .. so i am having hard time visualizing it ..so could you help a bit 🙂

@harikesh409
Copy link
Collaborator

@abhiraj-ku
You don't need to have a laptop of that size just use devtools to check those resolutions.

@abhiraj-ku
Copy link
Author

@harikesh409 i am actually having hard times figuring media queries for this resolution even using devtools so if you could suggest something that would be good 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@harikesh409 harikesh409 harikesh409 requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

change in ui of suggestedcodingsite.html
2 participants
@abhiraj-ku @harikesh409