Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

start with numa scaler 1, will be set to real value on EPN #1506

Merged
merged 1 commit into from
Feb 29, 2024

Conversation

shahor02
Copy link
Collaborator

No description provided.

Copy link

REQUEST FOR PRODUCTION RELEASES:
To request your PR to be included in production software, please add the corresponding labels called "async-" to your PR. Add the labels directly (if you have the permissions) or add a comment of the form (note that labels are separated by a ",")

+async-label <label1>, <label2>, !<label3> ...

This will add <label1> and <label2> and removes <label3>.

The following labels are available
async-2022-pp-apass4
async-2023-pbpb-apass
async-2023-pp-apass1
async-data
async-mc
async-2022-pp-apass6

Copy link
Collaborator

@davidrohr davidrohr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See my comment in #1505 1505

@shahor02
Copy link
Collaborator Author

@davidrohr I don't see where the RECO_NUM_NODES_WORKFLOW and NUMAGPUIDS are defined, isn't parser running for epns only?

@davidrohr
Copy link
Collaborator

RECO_NUM_NODES_WORKFLOW is defined in dpl-workflow.sh, and NUMAGPUIDS is defined in setenv.sh, so both should be available.
And the default should not be 1, it should be 230. If you set it to one, it will assume it has to do the load of all EPN nodes, so will multiply multiplicities by 230 with some cuts.

Anyhow, I would just move up the RECO_NUM_NODES_WORKFLOW_CMP definition, as I remarked in Chiara's PR.

@shahor02
Copy link
Collaborator Author

ok, thanks

@chiarazampolli
Copy link
Collaborator

Hello @shahor02 ,

Why did you add the labels? The problem was introduced by #1483, which is not in stable-async.

Chiara

@shahor02
Copy link
Collaborator Author

I thought it should be ported. Removed the labels.

@shahor02 shahor02 merged commit 95c2b21 into AliceO2Group:master Feb 29, 2024
6 checks passed
@shahor02 shahor02 deleted the pr_nnuma branch February 29, 2024 00:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants